Re: [Qemu-devel] [PATCH 1/7] tests: qgraph API for the qtest driver framework

[Stefan Hajnoczi]

On Wed, Jul 11, 2018 at 04:58:41PM +0200, Paolo Bonzini wrote:
> On 11/07/2018 16:28, Stefan Hajnoczi wrote:
> >> + *
> >> + * QOSGraphObject also provides a destructor, used to deallocate the
> >> + * after the test has been executed.
> >> + */
> >> +struct QOSGraphObject {
> >> +    /* for produces, returns void * */
> >> +    QOSGetDriver get_driver;
> > 
> > Unused?
> > 
> >> +    /* for contains, returns a QOSGraphObject * */
> >> +    QOSGetDevice get_device;
> > 
> > Unused?
> 
> What is unused?

Neither of these fields are used in this patch.  Please introduce them
in the first patch that actually uses them.  This way code review can
proceed linearly and it also prevents deadcode when just part of a patch
series is merged or backported.

signature.asc
Description: PGP signature