[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 04/40] target/mips: Add decode_nanomips_opc()
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v3 04/40] target/mips: Add decode_nanomips_opc() function |
Date: |
Thu, 19 Jul 2018 09:39:26 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 07/19/2018 05:54 AM, Stefan Markovic wrote:
> decode_opc(env, ctx);
> } else if (ctx->insn_flags & ASE_MICROMIPS) {
> - ctx->opcode = cpu_lduw_code(env, ctx->base.pc_next);
> - insn_bytes = decode_micromips_opc(env, ctx);
> + if (env->insn_flags & ISA_NANOMIPS32) {
Be consistent and use ctx->insn_flags.
> + ctx->opcode = cpu_lduw_code(env, ctx->base.pc_next);
> + insn_bytes = decode_nanomips_opc(env, ctx);
> + } else {
> + ctx->opcode = cpu_lduw_code(env, ctx->base.pc_next);
> + insn_bytes = decode_micromips_opc(env, ctx);
> + }
> } else if (ctx->insn_flags & ASE_MIPS16) {
> ctx->opcode = cpu_lduw_code(env, ctx->base.pc_next);
Do you really want to nest nanoMIPS within microMIPS?
I would have thought a better structure was
} else if (ctx->insn_flags & ISA_NANOMIPS32) {
...
} else if (ctx->insn_flags & ASE_MICROMIPS) {
...
} else if (ctx->insn_flags & ASE_MIPS16) {
r~
- Re: [Qemu-devel] [PATCH v3 16/40] target/mips: Implement emulation of nanoMIPS ROTX instruction, (continued)
- [Qemu-devel] [PATCH v3 13/40] target/mips: Add emulation of misc nanoMIPS instructions (pool32a0), Stefan Markovic, 2018/07/19
- [Qemu-devel] [PATCH v3 05/40] target/mips: Add nanoMIPS decoding and extraction utilities, Stefan Markovic, 2018/07/19
- [Qemu-devel] [PATCH v3 22/40] target/mips: Add handling of branch delay slots for nanoMIPS, Stefan Markovic, 2018/07/19
- [Qemu-devel] [PATCH v3 08/40] target/mips: Add emulation of nanoMIPS 16-bit logic instructions, Stefan Markovic, 2018/07/19
- [Qemu-devel] [PATCH v3 04/40] target/mips: Add decode_nanomips_opc() function, Stefan Markovic, 2018/07/19
- Re: [Qemu-devel] [PATCH v3 04/40] target/mips: Add decode_nanomips_opc() function,
Richard Henderson <=
- [Qemu-devel] [PATCH v3 09/40] target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions, Stefan Markovic, 2018/07/19
- [Qemu-devel] [PATCH v3 21/40] target/mips: Implement DSP ASE support for nanoMIPS, Stefan Markovic, 2018/07/19
- [Qemu-devel] [PATCH v3 28/40] target/mips: Adjust exception_resume_pc() for nanoMIPS, Stefan Markovic, 2018/07/19
- [Qemu-devel] [PATCH v3 18/40] target/mips: Add emulation of nanoMIPS 32-bit load and store instructions, Stefan Markovic, 2018/07/19