qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 15/40] target/mips: Add emulation of misc nan


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v3 15/40] target/mips: Add emulation of misc nanoMIPS instructions (pool p_lsx)
Date: Thu, 19 Jul 2018 12:19:00 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

On 07/19/2018 05:54 AM, Stefan Markovic wrote:
> +static void gen_p_lsx(DisasContext *ctx, int rd, int rs, int rt)
> +{
> +    TCGv t0, t1;
> +    t0 = tcg_temp_new();
> +    t1 = tcg_temp_new();
> +    tcg_gen_movi_tl(t1, 0);
> +    if (rs == 0) {
> +        tcg_gen_movi_tl(t0, 0);
> +    } else {
> +        gen_load_gpr(t0, rs);
> +    }
> +    if (rt == 0) {
> +        tcg_gen_movi_tl(t1, 0);
> +    } else {
> +        gen_load_gpr(t1, rt);
> +    }

gen_load_gpr already takes care of register 0.
And what is that initial redundant assignment to t1?


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]