Re: [Qemu-devel] [PATCH V10 10/20] qmp event: Add COLO_EXIT event to notify users while exited COLO

[Zhang Chen]

On Tue, Jul 24, 2018 at 2:41 AM, Eric Blake <address@hidden> wrote:

> On 07/22/2018 02:33 PM, Zhang Chen wrote:
>
>> From: zhanghailiang <address@hidden>
>>
>> If some errors happen during VM's COLO FT stage, it's important to
>> notify the users of this event. Together with 'x-colo-lost-heartbeat',
>> Users can intervene in COLO's failover work immediately.
>> If users don't want to get involved in COLO's failover verdict,
>> it is still necessary to notify users that we exited COLO mode.
>>
>> Signed-off-by: zhanghailiang <address@hidden>
>> Signed-off-by: Li Zhijian <address@hidden>
>> Signed-off-by: Zhang Chen <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> Reviewed-by: Markus Armbruster <address@hidden>
>> ---
>>   migration/colo.c    | 31 +++++++++++++++++++++++++++++++
>>   qapi/migration.json | 38 ++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 69 insertions(+)
>>
>
> At this point in the release cycle, this series feels like enough of a new
> feature (rather than a bug fix) that it is probably not appropriate for
> 3.0, which means...
>
>
> +++ b/qapi/migration.json
>> @@ -900,6 +900,44 @@
>>   { 'enum': 'FailoverStatus',
>>     'data': [ 'none', 'require', 'active', 'completed', 'relaunch' ] }
>>   +##
>> +# @COLO_EXIT:
>> +#
>> +# Emitted when VM finishes COLO mode due to some errors happening or
>> +# at the request of users.
>> +#
>> +# @mode: report COLO mode when COLO exited.
>> +#
>> +# @reason: describes the reason for the COLO exit.
>> +#
>> +# Since: 3.0
>>
>
> ...this and other references should be updated to 3.1.


OK, I will fix it and resend this series.

Thanks
Zhang Chen


>
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org
>