[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 11/24] replay: flush events when exiting
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [PATCH v5 11/24] replay: flush events when exiting |
Date: |
Wed, 25 Jul 2018 15:14:17 +0300 |
User-agent: |
StGit/0.17.1-dirty |
This patch adds events processing when emulation finishes instead
of just cleaning the queue. Now the bdrv coroutines will be in consistent
state when emulator closes. It allows correct polling of the block layer
at exit.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
replay/replay-events.c | 14 +-------------
replay/replay-internal.h | 2 --
2 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/replay/replay-events.c b/replay/replay-events.c
index 707de38..0964a82 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -94,18 +94,6 @@ void replay_disable_events(void)
}
}
-void replay_clear_events(void)
-{
- g_assert(replay_mutex_locked());
-
- while (!QTAILQ_EMPTY(&events_list)) {
- Event *event = QTAILQ_FIRST(&events_list);
- QTAILQ_REMOVE(&events_list, event, events);
-
- g_free(event);
- }
-}
-
/*! Adds specified async event to the queue */
void replay_add_event(ReplayAsyncEventKind event_kind,
void *opaque,
@@ -308,7 +296,7 @@ void replay_init_events(void)
void replay_finish_events(void)
{
events_enabled = false;
- replay_clear_events();
+ replay_flush_events();
}
bool replay_events_enabled(void)
diff --git a/replay/replay-internal.h b/replay/replay-internal.h
index 34d19eb..a2221e5 100644
--- a/replay/replay-internal.h
+++ b/replay/replay-internal.h
@@ -148,8 +148,6 @@ void replay_init_events(void);
void replay_finish_events(void);
/*! Flushes events queue */
void replay_flush_events(void);
-/*! Clears events list before loading new VM state */
-void replay_clear_events(void);
/*! Returns true if there are any unsaved events in the queue */
bool replay_has_events(void);
/*! Saves events from queue into the file */
- [Qemu-devel] [PATCH v5 01/24] block: implement bdrv_snapshot_goto for blkreplay, (continued)
- [Qemu-devel] [PATCH v5 01/24] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 02/24] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 03/24] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 04/24] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 05/24] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 06/24] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 07/24] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 08/24] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 09/24] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 10/24] replay: implement replay-seek command to proceed to the desired step, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 11/24] replay: flush events when exiting,
Pavel Dovgalyuk <=
- [Qemu-devel] [PATCH v5 12/24] timer: remove replay clock probe in deadline calculation, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 13/24] replay: refine replay-time module, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 14/24] translator: fix breakpoint processing, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 15/24] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 16/24] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 17/24] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 18/24] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 19/24] replay: allow loading any snapshots before recording, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 20/24] ps2: prevent changing irq state on save and load, Pavel Dovgalyuk, 2018/07/25
- [Qemu-devel] [PATCH v5 21/24] replay: wake up vCPU when replaying, Pavel Dovgalyuk, 2018/07/25