|
From: | Leonid Bloch |
Subject: | Re: [Qemu-devel] [PATCH v5 2/4 for-3.0] qcow2: Options' documentation fixes |
Date: | Thu, 26 Jul 2018 17:30:30 +0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 07/26/2018 05:20 PM, Eric Blake wrote:
On 07/26/2018 05:02 AM, Kevin Wolf wrote:Am 25.07.2018 um 16:27 hat Leonid Bloch geschrieben:Signed-off-by: Leonid Bloch <address@hidden> --- docs/qcow2-cache.txt | 3 +++ qemu-options.hx | 10 ++++++---- 2 files changed, 9 insertions(+), 4 deletions(-)+++ b/qemu-options.hx @@ -752,15 +752,17 @@ image file) @item cache-sizeThe maximum total size of the L2 table and refcount block caches in bytes-(default: 1048576 bytes or 8 clusters, whichever is larger)I think it would be good to still say something about the default. Maybe something like "default: the sum of l2-cache-size and refcount-cache-size"?Except what happens if you specify only one of l2-cache-size or refcount-cache-size? Is the defaulted cache-size then just that one size you specified (and the other cache ignored), or is the total cache size still defaulted to the 1M/8-cluster size (assuming its larger than the other size specified)?
I think that the meaning here is the sum of the actual l2-cache-size and refcount-cache-size. Not the specified options, but the actual caches.
Leonid.
[Prev in Thread] | Current Thread | [Next in Thread] |