[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qstring: Fix qstring_from_substr() not to provo
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH] qstring: Fix qstring_from_substr() not to provoke int overflow |
|
Date: |
Fri, 27 Jul 2018 14:34:26 +0100 |
|
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Wed, Jul 25, 2018 at 11:21:03AM +0200, Markus Armbruster wrote:
> liujunjie <address@hidden> writes:
> > diff --git a/qobject/qstring.c b/qobject/qstring.c
> > index afca54b..18b8eb8 100644
> > --- a/qobject/qstring.c
> > +++ b/qobject/qstring.c
> > @@ -37,7 +37,7 @@ size_t qstring_get_length(const QString *qstring)
> > *
> > * Return string reference
> > */
> > -QString *qstring_from_substr(const char *str, int start, int end)
> > +QString *qstring_from_substr(const char *str, size_t start, size_t end)
> > {
> > QString *qstring;
>
> Reviewed-by: Markus Armbruster <address@hidden>
>
None more qualified to merge this than you:
$ scripts/get_maintainer.pl -f qobject/qstring.c
Markus Armbruster <address@hidden> (supporter:QObject)
address@hidden (open list:All patches CC here)
:)
signature.asc
Description: PGP signature