[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [qemu-s390x] [PATCH v1] s390x/cpu_models: Add "-cpu max
From: |
David Hildenbrand |
Subject: |
Re: [Qemu-devel] [qemu-s390x] [PATCH v1] s390x/cpu_models: Add "-cpu max" support |
Date: |
Fri, 27 Jul 2018 16:57:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
> If we had a S390KVMAccelerator object on machine->accelerator,
> S390KVMAccelerator::host_model would be a good candidate?
Depends if at that point the machine would already be initialized (we
disable CPU model support for KVM on some legacy machine due to
interactions). It's complicated :)
[...]
>> Right now the semantics are clear: if we have "!cpu->model" after the
>> object has been created, details about the host CPU model are not
>> available (models unavailable/unsupported). Modifying properties,
>> baselining, expanding is not possible with that model then. But it can
>> be used for execution.
>
> This is interesting. If most users of cpu->model don't care
> about kvm_s390_get_host_cpu_model() errors at all, the current
> solution sounds more reasonable.
>
> Except for the error_report_err() call inside instance_init.
> This still bothers me, but it's not a big deal.
Yes, we should refactor that. I'll add this to my TODO list!
--
Thanks,
David / dhildenb
- Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support, (continued)
Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support, Eduardo Habkost, 2018/07/25
Re: [Qemu-devel] [PATCH v1] s390x/cpu_models: Add "-cpu max" support, Cornelia Huck, 2018/07/27