[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.0 1/3] block/qapi: Add 'qdev' field to que
From: |
Peter Krempa |
Subject: |
Re: [Qemu-devel] [PATCH for-3.0 1/3] block/qapi: Add 'qdev' field to query-blockstats result |
Date: |
Mon, 30 Jul 2018 13:25:45 +0200 |
User-agent: |
Mutt/1.9.3 (2018-01-21) |
On Fri, Jul 27, 2018 at 17:58:54 +0200, Kevin Wolf wrote:
> Am 27.07.2018 um 17:07 hat Eric Blake geschrieben:
> > On 07/27/2018 09:15 AM, Kevin Wolf wrote:
> > > Like for query-block, the client needs to identify which BlockBackend
> > > the returned data is for. Anonymous BlockBackends are identified by the
> > > device model they are attached to. Add a 'qdev' field that contains the
> > > qdev ID or QOM path of the attached device model.
> > >
> > > Signed-off-by: Kevin Wolf <address@hidden>
> > > ---
> >
> > > @@ -879,7 +882,7 @@
> > > # Since: 0.14.0
> > > ##
> > > { 'struct': 'BlockStats',
> > > - 'data': {'*device': 'str', '*node-name': 'str',
> > > + 'data': {'*device': 'str', '*qdev': 'str', '*node-name': 'str',
> > > 'stats': 'BlockDeviceStats',
> > > '*parent': 'BlockStats',
> > > '*backing': 'BlockStats'} }
> >
> > Can we also update the example under query-blockstats a few lines later to
> > show the added field?
>
> I'll add the qdev field, but the example is hopelessly outdated anyway.
> Sounds like something for another patch.
When doing further cleanups it would be worth also noting that the
'query-nodes' argument of 'query-blockstats' does not return correct
information.
Right now it creates a false impression that it just changes the output
from nested to linear and includes filter nodes, but in fact the data is
not correct in that mode.
signature.asc
Description: PGP signature