Re: [Qemu-devel] [PATCH v5 39/76] target/mips: Add emulation of DSP ASE for nanoMIPS - part 2

[Richard Henderson]

On 07/30/2018 12:12 PM, Aleksandar Markovic wrote:

> +                case NM_BPOSGE32C:
> +                    check_dsp(ctx);
> +                    {
> +                        int32_t imm = ctx->opcode;
> +                        imm >>= 1;
> +                        imm &= 0x1fff;
> +                        imm |= (ctx->opcode & 1) << 13;

extract32.

> +
> +                        gen_compute_branch(ctx, OPC_BPOSGE32, 4, -1, -2,
> +                                           (int32_t)imm, 4);

Useless cast.  And see my other response re gen_compute_branch.


r~