Re: [Qemu-devel] [PATCH v5 51/76] target/mips: Adjust set_pc() for nanoMIPS

[Richard Henderson]

On 07/30/2018 12:12 PM, Aleksandar Markovic wrote:
> From: James Hogan <address@hidden>
> 
> ERET and ERETNC shouldn't clear MIPS_HFLAG_M16 for nanoMIPS since there
> is no ISA bit, so fix set_pc() to skip the hflags update.
> 
> Signed-off-by: James Hogan <address@hidden>
> Signed-off-by: Yongbok Kim <address@hidden>
> Signed-off-by: Aleksandar Markovic <address@hidden>
> Signed-off-by: Stefan Markovic <address@hidden>
> Reviewed-by: Aleksandar Markovic <address@hidden>
> ---
>  target/mips/op_helper.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/target/mips/op_helper.c b/target/mips/op_helper.c
> index 5e10286..c55a1e6 100644
> --- a/target/mips/op_helper.c
> +++ b/target/mips/op_helper.c
> @@ -2428,6 +2428,10 @@ static void debug_post_eret(CPUMIPSState *env)
>  static void set_pc(CPUMIPSState *env, target_ulong error_pc)
>  {
>      env->active_tc.PC = error_pc & ~(target_ulong)1;

You don't want this for nanomips either, surely.

> +    if (env->insn_flags & ISA_NANOMIPS32) {
> +        /* Don't clear MIPS_HFLAG_M16 */
> +        return;
> +    }

Likewise re nanomips not setting M16.


r~