[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] fix "Missing break in switch" coverity reports
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] fix "Missing break in switch" coverity reports |
|
Date: |
Wed, 1 Aug 2018 17:26:26 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 01/08/2018 17:25, Philippe Mathieu-Daudé wrote:
>
> @@ -12277,6 +12277,7 @@ int arm_rmode_to_sf(int rmode)
> /* FIXME: add support for TIEAWAY and ODD */
> qemu_log_mask(LOG_UNIMP, "arm: unimplemented rounding mode:
> %d\n",
> rmode);
> + /* fall through for now */
>
>
> This one looks weird, hidden bug?
There is already a FIXME comment.
Paolo
> For the rest:
>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden
> <mailto:address@hidden>>