[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 07/76] elf: Remove duplicate preprocessor con
|
From: |
Laurent Vivier |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 07/76] elf: Remove duplicate preprocessor constant definition |
|
Date: |
Wed, 1 Aug 2018 22:31:35 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
Le 01/08/2018 à 22:01, Aleksandar Markovic a écrit :
>>
>> From: Peter Maydell <address@hidden>
>> Sent: Wednesday, August 1, 2018 9:37 PM
>>
>>> The simplest way to do that is just to delete
>>> the second (original) EF_MIPS_ARCH #define, the one just
>>> below the EF_MIPS_NAN2008 define.
>>>
>>> We could line up with the order the glibc headers use, but
>>> that seems like overkill compared to just deleting a line.
>>
>
> This sounds reasonable to me, and, if nobody disputes it, I will implement it
> this way in the next version.
I agree
Laurent