[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 03/77] target/mips: Mark switch fallthroughs with
From: |
Stefan Markovic |
Subject: |
[Qemu-devel] [PATCH v6 03/77] target/mips: Mark switch fallthroughs with interpretable comments |
Date: |
Thu, 2 Aug 2018 16:15:50 +0200 |
From: Aleksandar Markovic <address@hidden>
Mark switch fallthroughs with comments, in cases fallthroughs
are intentional.
The comments "/* fall through */" are interpreted by compilers and
other tools, and they will not issue warnings in such cases. For gcc,
the warning is turnend on by -Wimplicit-fallthrough. With this patch,
there will be no such warnings in target/mips directory. If such
warning appears in future, it should be checked if it is intentional,
and, if yes, marked with a comment similar to those from this patch.
The comment must be just before next "case", otherwise gcc won't
understand it.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Signed-off-by: Stefan Markovic <address@hidden>
---
target/mips/translate.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/target/mips/translate.c b/target/mips/translate.c
index 051dda5..e32fd5f 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -14255,8 +14255,8 @@ static void decode_micromips32_opc(CPUMIPSState *env,
DisasContext *ctx)
case SDP:
check_insn(ctx, ISA_MIPS3);
check_mips_64(ctx);
- /* Fallthrough */
#endif
+ /* fall through */
case LWP:
case SWP:
gen_ldst_pair(ctx, minor, rt, rs, SIMM(ctx->opcode, 0, 12));
@@ -14266,8 +14266,8 @@ static void decode_micromips32_opc(CPUMIPSState *env,
DisasContext *ctx)
case SDM:
check_insn(ctx, ISA_MIPS3);
check_mips_64(ctx);
- /* Fallthrough */
#endif
+ /* fall through */
case LWM32:
case SWM32:
gen_ldst_multiple(ctx, minor, rt, rs, SIMM(ctx->opcode, 0, 12));
@@ -20023,6 +20023,7 @@ static void decode_opc(CPUMIPSState *env, DisasContext
*ctx)
case OPC_MTHC1:
check_cp1_enabled(ctx);
check_insn(ctx, ISA_MIPS32R2);
+ /* fall through */
case OPC_MFC1:
case OPC_CFC1:
case OPC_MTC1:
--
1.9.1
- [Qemu-devel] [PATCH v6 00/77] Add nanoMIPS support to QEMU, Stefan Markovic, 2018/08/02
- [Qemu-devel] [PATCH v6 01/77] MAINTAINERS: Update target/mips maintainer's email addresses, Stefan Markovic, 2018/08/02
- [Qemu-devel] [PATCH v6 02/77] target/mips: Avoid case statements formulated by ranges, Stefan Markovic, 2018/08/02
- [Qemu-devel] [PATCH v6 03/77] target/mips: Mark switch fallthroughs with interpretable comments,
Stefan Markovic <=
- [Qemu-devel] [PATCH v6 04/77] target/mips: Fix two instances of shadow variables, Stefan Markovic, 2018/08/02
- [Qemu-devel] [PATCH v6 05/77] target/mips: Update some CP0 registers bit definitions, Stefan Markovic, 2018/08/02
- [Qemu-devel] [PATCH v6 06/77] target/mips: Add CP0 BadInstrX register, Stefan Markovic, 2018/08/02
- [Qemu-devel] [PATCH v6 07/77] target/mips: Add gen_op_addr_addi(), Stefan Markovic, 2018/08/02
- [Qemu-devel] [PATCH v6 08/77] target/mips: Don't update BadVAddr register in Debug Mode, Stefan Markovic, 2018/08/02
- [Qemu-devel] [PATCH v6 09/77] target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0, Stefan Markovic, 2018/08/02
- [Qemu-devel] [PATCH v6 10/77] elf: Remove duplicate preprocessor constant definition, Stefan Markovic, 2018/08/02
- [Qemu-devel] [PATCH v6 11/77] elf: Add ELF flags for MIPS machine variants, Stefan Markovic, 2018/08/02
- [Qemu-devel] [PATCH v6 12/77] linux-user: Update MIPS syscall numbers up to kernel 4.18 headers, Stefan Markovic, 2018/08/02
- [Qemu-devel] [PATCH v6 13/77] linux-user: Add preprocessor availability control to some syscalls, Stefan Markovic, 2018/08/02