[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 21/23] libqtest: Enable compile-time format strin
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v3 21/23] libqtest: Enable compile-time format string checking |
Date: |
Mon, 6 Aug 2018 08:53:42 +0200 |
qtest_qmp() & friends pass their format string and variable arguments
to qobject_from_vjsonf_nofail(). Unlike qobject_from_jsonv(), they
aren't decorated with GCC_FMT_ATTR(). Fix that to get compile-time
format string checking.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
tests/libqtest.h | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/tests/libqtest.h b/tests/libqtest.h
index d3da42623e..712ac023d6 100644
--- a/tests/libqtest.h
+++ b/tests/libqtest.h
@@ -82,7 +82,8 @@ void qtest_quit(QTestState *s);
*
* Sends a QMP message to QEMU and returns the response.
*/
-QDict *qtest_qmp(QTestState *s, const char *fmt, ...);
+QDict *qtest_qmp(QTestState *s, const char *fmt, ...)
+ GCC_FMT_ATTR(2, 3);
/**
* qtest_qmp_send:
@@ -93,7 +94,8 @@ QDict *qtest_qmp(QTestState *s, const char *fmt, ...);
*
* Sends a QMP message to QEMU and leaves the response in the stream.
*/
-void qtest_qmp_send(QTestState *s, const char *fmt, ...);
+void qtest_qmp_send(QTestState *s, const char *fmt, ...)
+ GCC_FMT_ATTR(2, 3);
/**
* qtest_qmpv:
@@ -105,7 +107,8 @@ void qtest_qmp_send(QTestState *s, const char *fmt, ...);
*
* Sends a QMP message to QEMU and returns the response.
*/
-QDict *qtest_qmpv(QTestState *s, const char *fmt, va_list ap);
+QDict *qtest_qmpv(QTestState *s, const char *fmt, va_list ap)
+ GCC_FMT_ATTR(2, 0);
/**
* qtest_qmp_vsend:
@@ -117,7 +120,8 @@ QDict *qtest_qmpv(QTestState *s, const char *fmt, va_list
ap);
*
* Sends a QMP message to QEMU and leaves the response in the stream.
*/
-void qtest_qmp_vsend(QTestState *s, const char *fmt, va_list ap);
+void qtest_qmp_vsend(QTestState *s, const char *fmt, va_list ap)
+ GCC_FMT_ATTR(2, 0);
/**
* qtest_receive:
@@ -574,7 +578,7 @@ static inline void qtest_end(void)
*
* Sends a QMP message to QEMU and returns the response.
*/
-QDict *qmp(const char *fmt, ...);
+QDict *qmp(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
/**
* qmp_send:
@@ -584,7 +588,7 @@ QDict *qmp(const char *fmt, ...);
*
* Sends a QMP message to QEMU and leaves the response in the stream.
*/
-void qmp_send(const char *fmt, ...);
+void qmp_send(const char *fmt, ...) GCC_FMT_ATTR(1, 2);
/**
* qmp_receive:
@@ -943,10 +947,10 @@ static inline int64_t clock_set(int64_t val)
}
QDict *qmp_fd_receive(int fd);
-void qmp_fd_vsend(int fd, const char *fmt, va_list ap);
-void qmp_fd_send(int fd, const char *fmt, ...);
-QDict *qmp_fdv(int fd, const char *fmt, va_list ap);
-QDict *qmp_fd(int fd, const char *fmt, ...);
+void qmp_fd_vsend(int fd, const char *fmt, va_list ap) GCC_FMT_ATTR(2, 0);
+void qmp_fd_send(int fd, const char *fmt, ...) GCC_FMT_ATTR(2, 3);
+QDict *qmp_fdv(int fd, const char *fmt, va_list ap) GCC_FMT_ATTR(2, 0);
+QDict *qmp_fd(int fd, const char *fmt, ...) GCC_FMT_ATTR(2, 3);
/**
* qtest_cb_for_every_machine:
--
2.17.1
- Re: [Qemu-devel] [PATCH v3 23/23] libqtest: Rename qtest_FOOv() to qtest_vFOO() for consistency, (continued)
- [Qemu-devel] [PATCH v3 15/23] migration-test: Make wait_command() return the "return" member, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 22/23] libqtest: Replace qtest_startf() by qtest_initf(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 20/23] migration-test: Clean up string interpolation into QMP, part 3, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 11/23] tests: Pass literal format strings directly to qmp_FOO(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 06/23] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 02/23] libqtest: Clean up how we read device_del messages, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 10/23] qobject: qobject_from_jsonv() is dangerous, hide it away, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 01/23] libqtest: Rename functions to send QMP messages, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 18/23] migration-test: Clean up string interpolation into QMP, part 1, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 21/23] libqtest: Enable compile-time format string checking,
Markus Armbruster <=
- [Qemu-devel] [PATCH v3 19/23] migration-test: Clean up string interpolation into QMP, part 2, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 16/23] tests: New helper qtest_qmp_receive_success(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 14/23] tests: Clean up string interpolation around qtest_qmp_device_add(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 12/23] tests: Clean up string interpolation into QMP input (simple cases), Markus Armbruster, 2018/08/06