[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 04/23] libqtest: Remove qtest_qmp_discard_res
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v3 04/23] libqtest: Remove qtest_qmp_discard_response() & friends |
Date: |
Mon, 6 Aug 2018 09:02:27 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 08/06/2018 08:53 AM, Markus Armbruster wrote:
> qtest_qmp_discard_response(...) is shorthand for
> qobject_unref(qtest_qmp(...), except it's not actually shorter.
> Moreover, the presence of these functions encourage sloppy testing.
> Remove them from libqtest. Add them as macros to the tests that use
> them, with a TODO comment asking for cleanup.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> tests/ahci-test.c | 3 +++
> tests/boot-order-test.c | 5 ++++-
> tests/drive_del-test.c | 3 +++
> tests/fdc-test.c | 4 ++++
> tests/ide-test.c | 5 ++++-
> tests/libqtest.c | 27 +--------------------------
> tests/libqtest.h | 27 ---------------------------
> tests/migration-test.c | 3 +++
> tests/test-filter-mirror.c | 4 ++++
> tests/test-filter-redirector.c | 4 ++++
> tests/virtio-blk-test.c | 4 ++++
> 11 files changed, 34 insertions(+), 55 deletions(-)
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v3 00/23] tests: Compile-time format string checking for libqtest.h, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 08/23] libqtest: Simplify qmp_fd_vsend() a bit, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 09/23] test-qobject-input-visitor: Avoid format string ambiguity, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 13/23] cpu-plug-test: Don't pass integers as strings to device_add, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 07/23] qobject: New qobject_from_vjsonf_nofail(), qdict_from_vjsonf_nofail(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 03/23] libqtest: Clean up how we read the QMP greeting, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 05/23] libqtest: Document calling conventions, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 17/23] migration-test: Make wait_command() cope with '%', Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 04/23] libqtest: Remove qtest_qmp_discard_response() & friends, Markus Armbruster, 2018/08/06
- Re: [Qemu-devel] [PATCH v3 04/23] libqtest: Remove qtest_qmp_discard_response() & friends,
Thomas Huth <=
- [Qemu-devel] [PATCH v3 23/23] libqtest: Rename qtest_FOOv() to qtest_vFOO() for consistency, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 15/23] migration-test: Make wait_command() return the "return" member, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 22/23] libqtest: Replace qtest_startf() by qtest_initf(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 20/23] migration-test: Clean up string interpolation into QMP, part 3, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 11/23] tests: Pass literal format strings directly to qmp_FOO(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 06/23] qobject: Replace qobject_from_jsonf() by qobject_from_jsonf_nofail(), Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 02/23] libqtest: Clean up how we read device_del messages, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 10/23] qobject: qobject_from_jsonv() is dangerous, hide it away, Markus Armbruster, 2018/08/06
- [Qemu-devel] [PATCH v3 01/23] libqtest: Rename functions to send QMP messages, Markus Armbruster, 2018/08/06