[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 6/7] qcow2: refactor qcow2_co_pwritev locals scope
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-devel] [PATCH 6/7] qcow2: refactor qcow2_co_pwritev locals scope |
Date: |
Tue, 7 Aug 2018 20:43:10 +0300 |
Move local variables related to individual loop iteration into while
block.
Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
---
block/qcow2.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 4d669432d1..88b3fb8080 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -2294,10 +2294,7 @@ static coroutine_fn int
qcow2_co_pwritev(BlockDriverState *bs, uint64_t offset,
int flags)
{
BDRVQcow2State *s = bs->opaque;
- int offset_in_cluster;
int ret;
- unsigned int cur_bytes; /* number of sectors in current iteration */
- uint64_t cluster_offset;
QEMUIOVector hd_qiov;
uint64_t bytes_done = 0;
uint8_t *cluster_data = NULL;
@@ -2312,12 +2309,14 @@ static coroutine_fn int
qcow2_co_pwritev(BlockDriverState *bs, uint64_t offset,
qemu_co_mutex_lock(&s->lock);
while (bytes != 0) {
+ int offset_in_cluster = offset_into_cluster(s, offset);
+ unsigned int cur_bytes = MIN(bytes, INT_MAX); /* number of sectors in
+ current iteration */
+ uint64_t cluster_offset;
l2meta = NULL;
trace_qcow2_writev_start_part(qemu_coroutine_self());
- offset_in_cluster = offset_into_cluster(s, offset);
- cur_bytes = MIN(bytes, INT_MAX);
if (bs->encrypted) {
cur_bytes = MIN(cur_bytes,
QCOW_MAX_CRYPT_CLUSTERS * s->cluster_size
--
2.11.1
- [Qemu-devel] [PATCH 0/7] qcow2: async handling of fragmented io, Vladimir Sementsov-Ogievskiy, 2018/08/07
- [Qemu-devel] [PATCH 1/7] qcow2: move qemu_co_mutex_lock below decryption procedure, Vladimir Sementsov-Ogievskiy, 2018/08/07
- [Qemu-devel] [PATCH 6/7] qcow2: refactor qcow2_co_pwritev locals scope,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-devel] [PATCH 2/7] qcow2: bdrv_co_pwritev: move encryption code out of lock, Vladimir Sementsov-Ogievskiy, 2018/08/07
- [Qemu-devel] [PATCH 3/7] qcow2: split out reading normal clusters from qcow2_co_preadv, Vladimir Sementsov-Ogievskiy, 2018/08/07
- [Qemu-devel] [PATCH 4/7] qcow2: async scheme for qcow2_co_preadv, Vladimir Sementsov-Ogievskiy, 2018/08/07
- [Qemu-devel] [PATCH 5/7] qcow2: refactor qcow2_co_pwritev: split out qcow2_co_do_pwritev, Vladimir Sementsov-Ogievskiy, 2018/08/07
- [Qemu-devel] [PATCH 7/7] qcow2: async scheme for qcow2_co_pwritev, Vladimir Sementsov-Ogievskiy, 2018/08/07
- Re: [Qemu-devel] [PATCH 0/7] qcow2: async handling of fragmented io, Max Reitz, 2018/08/15