Re: [Qemu-devel] [PATCH v3 01/10] migration: do not wait for free thread

[Xiao Guangrong]

On 08/08/2018 11:51 AM, Peter Xu wrote:
> On Tue, Aug 07, 2018 at 08:29:54AM -0500, Eric Blake wrote:
> > On 08/07/2018 04:12 AM, address@hidden wrote:
> > > From: Xiao Guangrong <address@hidden>
> > >
> > > Instead of putting the main thread to sleep state to wait for
> > > free compression thread, we can directly post it out as normal
> > > page that reduces the latency and uses CPUs more efficiently
> > >
> > > A parameter, compress-wait-thread, is introduced, it can be
> > > enabled if the user really wants the old behavior
> > >
> > > Signed-off-by: Xiao Guangrong <address@hidden>
> > > ---
> >
> > > +++ b/qapi/migration.json
> > > @@ -462,6 +462,11 @@
> > >    # @compress-threads: Set compression thread count to be used in live 
> > > migration,
> > >    #          the compression thread count is an integer between 1 and 255.
> > >    #
> > > +# @compress-wait-thread: Wait if no thread is free to compress the memory page
> > > +#          if it's enabled, otherwise, the page will be posted out immediately
> > > +#          in the main thread without compression. It's true on default.
> > > +#          (Since: 3.1)
> >
> > Grammar suggestion:
> >
> > @compress-wait-thread: Controls behavior when all compression threads are
> > currently busy. If true (default), wait for a free compression thread to
> > become available; otherwise, send the page uncompressed. (Since 3.1)
>
> Eric's version seems better.  With that:

It's good to me too. Will apply Eric's suggestion in the next version.

> Reviewed-by: Peter Xu <address@hidden>

Thank you, Peter and Eric.