[Qemu-devel] [PATCH 11/29] vmsvga: Remove handler of SVGA_CMD_INVALID_CMD

[Liran Alon]

From: Leonid Shatz <address@hidden>

This should be better handled by switch default case, which will output 
debugging
message about encountering this command, instead of silently discarding.
If such command is ever encountered, it serves as indicator of broken FIFO
command decoding chain.

Signed-off-by: Leonid Shatz <address@hidden>
Reviewed-by: Darren Kenny <address@hidden>
Signed-off-by: Liran Alon <address@hidden>
---
 hw/display/vmware_vga.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
index c30ae9b4b204..f0e6b4bc74ba 100644
--- a/hw/display/vmware_vga.c
+++ b/hw/display/vmware_vga.c
@@ -776,13 +776,6 @@ static void vmsvga_fifo_run(struct vmsvga_state_s *s)
             args = 1;
             goto badcmd;
 
-        /*
-         * Other commands that are not listed as depending on any
-         * CAPABILITIES bits, but are not described in the README either.
-         */
-        case SVGA_CMD_INVALID_CMD:
-            break; /* Nop */
-
         default:
             args = 0;
             goto badcmd;
-- 
1.9.1