Re: [Qemu-devel] [PATCH v2 07/34] tests/qgraph: arm/raspi2 machine node

[Laurent Vivier]

On 06/08/2018 16:33, Emanuele Giuseppe Esposito wrote:
> Add arm/raspi2 machine to the graph. This machine contains a generic-sdhci, so
> its constructor must take care of setting it properly when called.
> 
> Signed-off-by: Emanuele Giuseppe Esposito <address@hidden>
> ---
>  tests/Makefile.include        |  1 +
>  tests/libqos/raspi2-machine.c | 82 +++++++++++++++++++++++++++++++++++
>  2 files changed, 83 insertions(+)
>  create mode 100644 tests/libqos/raspi2-machine.c

globally, same cosmetic comments (destructor, fprintf, register, ...) as
for PC, otherwise it looks good.

Thanks,
Laurent