[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/34] tests/qgraph: arm/raspi2 machine node
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH v2 07/34] tests/qgraph: arm/raspi2 machine node |
Date: |
Thu, 9 Aug 2018 14:35:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 06/08/2018 16:33, Emanuele Giuseppe Esposito wrote:
> Add arm/raspi2 machine to the graph. This machine contains a generic-sdhci, so
> its constructor must take care of setting it properly when called.
>
> Signed-off-by: Emanuele Giuseppe Esposito <address@hidden>
> ---
> tests/Makefile.include | 1 +
> tests/libqos/raspi2-machine.c | 82 +++++++++++++++++++++++++++++++++++
> 2 files changed, 83 insertions(+)
> create mode 100644 tests/libqos/raspi2-machine.c
globally, same cosmetic comments (destructor, fprintf, register, ...) as
for PC, otherwise it looks good.
Thanks,
Laurent
[Qemu-devel] [PATCH v2 06/34] tests/qgraph: sdhci test node, Emanuele Giuseppe Esposito, 2018/08/06
[Qemu-devel] [PATCH v2 08/34] tests/qgraph: rename qpci_init_spapr functions, Emanuele Giuseppe Esposito, 2018/08/06
[Qemu-devel] [PATCH v2 07/34] tests/qgraph: arm/raspi2 machine node, Emanuele Giuseppe Esposito, 2018/08/06
- Re: [Qemu-devel] [PATCH v2 07/34] tests/qgraph: arm/raspi2 machine node,
Laurent Vivier <=
[Qemu-devel] [PATCH v2 10/34] tests/qgraph: ppc64/pseries machine node, Emanuele Giuseppe Esposito, 2018/08/06
[Qemu-devel] [PATCH v2 09/34] tests/qgraph: pci-spapr driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/06
[Qemu-devel] [PATCH v2 11/34] test/qgraph: e1000e driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/06
[Qemu-devel] [PATCH v2 01/34] tests: qgraph API for the qtest driver framework, Emanuele Giuseppe Esposito, 2018/08/06
[Qemu-devel] [PATCH v2 12/34] test/qgraph: e1000e-test node, Emanuele Giuseppe Esposito, 2018/08/06
[Qemu-devel] [PATCH v2 13/34] test/qgraph: virtio_start_device function, Emanuele Giuseppe Esposito, 2018/08/06