[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/56] check-qjson: Streamline escaped_string()'
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 08/56] check-qjson: Streamline escaped_string()'s test strings |
Date: |
Fri, 10 Aug 2018 16:15:15 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 08/08/2018 07:02 AM, Markus Armbruster wrote:
>> Merge a few closely related test strings, and drop a few redundant
>> ones.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> tests/check-qjson.c | 14 ++------------
>> 1 file changed, 2 insertions(+), 12 deletions(-)
>>
>
>> } test_cases[] = {
>> - { "\\b", "\b" },
>> - { "\\f", "\f" },
>> - { "\\n", "\n" },
>> - { "\\r", "\r" },
>> - { "\\t", "\t" },
>> - { "/", "/" },
>> - { "\\/", "/", .skip = 1 },
>> - { "\\\\", "\\" },
>> - { "\\\"", "\"" },
>> - { "hello world \\\"embedded string\\\"",
>> - "hello world \"embedded string\"" },
>> - { "hello world\\nwith new line", "hello world\nwith new line" },
>> + { "\\b\\f\\n\\r\\t\\\\\\\"", "\b\f\n\r\t\\\"" },
>> + { "\\/\\'", "/'", .skip = 1 },
>
> Aha - this adds coverage of the escaped ' not present in 7/56.
You're right. I'll move that part there.
> Aha - this adds coverage of the escaped ' not present in 7/56. (Still
> nothing about the unescaped versions of ' or " with correct quoting).
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 03/56] check-qjson: Cover whitespace more thoroughly, (continued)
- [Qemu-devel] [PATCH 03/56] check-qjson: Cover whitespace more thoroughly, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 07/56] check-qjson: Cover escaped characters more thoroughly, part 1, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 08/56] check-qjson: Streamline escaped_string()'s test strings, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 35/56] json: Don't create JSON_ERROR tokens that won't be used, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 17/56] json: Reject unescaped control characters, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 23/56] json: Leave rejecting invalid UTF-8 to parser, Markus Armbruster, 2018/08/08
- [Qemu-devel] [PATCH 18/56] json: Revamp lexer documentation, Markus Armbruster, 2018/08/08