[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 33/33] tests/qgraph: temporarly commented vhost-
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 33/33] tests/qgraph: temporarly commented vhost-user-test |
Date: |
Mon, 13 Aug 2018 13:22:52 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 13/08/2018 13:15, Michael S. Tsirkin wrote:
> On Mon, Aug 13, 2018 at 12:14:53PM +0200, Emanuele Giuseppe Esposito wrote:
>> vhost-user-test has not converted to qgraph yet, and since
>> it uses virtio interface, it won't work, causing make check
>> to fail.
>> Commented out until it does not get converted to graph node.
>>
>> Signed-off-by: Emanuele Giuseppe Esposito <address@hidden>
>
> Two problems with that
> - we lose vhost user coverage
> - bisecting to before patch 33 will leave us with
> a failing make check
See $SUBJECT, "temporarily". :)
Paolo
>
>> ---
>> tests/Makefile.include | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>> index 15926cc95f..30355058fc 100644
>> --- a/tests/Makefile.include
>> +++ b/tests/Makefile.include
>> @@ -287,10 +287,10 @@ check-qtest-i386-y += tests/cpu-plug-test$(EXESUF)
>> check-qtest-i386-y += tests/q35-test$(EXESUF)
>> check-qtest-i386-y += tests/vmgenid-test$(EXESUF)
>> gcov-files-i386-y += hw/pci-host/q35.c
>> -check-qtest-i386-$(CONFIG_VHOST_USER_NET_TEST_i386) +=
>> tests/vhost-user-test$(EXESUF)
>> -ifeq ($(CONFIG_VHOST_USER_NET_TEST_i386),)
>> -check-qtest-x86_64-$(CONFIG_VHOST_USER_NET_TEST_x86_64) +=
>> tests/vhost-user-test$(EXESUF)
>> -endif
>> +# check-qtest-i386-$(CONFIG_VHOST_USER_NET_TEST_i386) +=
>> tests/vhost-user-test$(EXESUF)
>> +# ifeq ($(CONFIG_VHOST_USER_NET_TEST_i386),)
>> +# check-qtest-x86_64-$(CONFIG_VHOST_USER_NET_TEST_x86_64) +=
>> tests/vhost-user-test$(EXESUF)
>> +# endif
>> check-qtest-i386-$(CONFIG_TPM) += tests/tpm-crb-swtpm-test$(EXESUF)
>> check-qtest-i386-$(CONFIG_TPM) += tests/tpm-crb-test$(EXESUF)
>> check-qtest-i386-$(CONFIG_TPM) += tests/tpm-tis-swtpm-test$(EXESUF)
>> --
>> 2.17.1
- [Qemu-devel] [PATCH 24/33] tests/qgraph: virtio-balloon test node, (continued)
- [Qemu-devel] [PATCH 24/33] tests/qgraph: virtio-balloon test node, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-devel] [PATCH 25/33] tests/qgraph: virtio-rng driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-devel] [PATCH 27/33] tests/qgraph: virtio-blk driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-devel] [PATCH 29/33] tests/qgraph: virtio-net driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-devel] [PATCH 26/33] tests/qgraph: virtio-rng test node, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-devel] [PATCH 30/33] tests/qgraph: virtio-net test node, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-devel] [PATCH 28/33] tests/qgraph: virtio-blk test node, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-devel] [PATCH 31/33] tests/qgraph: virtio-scsi driver and interface nodes, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-devel] [PATCH 33/33] tests/qgraph: temporarly commented vhost-user-test, Emanuele Giuseppe Esposito, 2018/08/13
- [Qemu-devel] [PATCH 32/33] tests/qgraph: virtio-scsi test node, Emanuele Giuseppe Esposito, 2018/08/13
- Re: [Qemu-devel] [PATCH 00/33] Qtest driver framework, Michael S. Tsirkin, 2018/08/13
- Re: [Qemu-devel] [PATCH 00/33] Qtest driver framework, Markus Armbruster, 2018/08/15