[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] RFC: fix megasas leak
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] RFC: fix megasas leak |
Date: |
Tue, 14 Aug 2018 08:26:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 09/08/2018 13:44, Marc-André Lureau wrote:
>
> I suppose megasas_complete_command() should take care of destroying
> the sglist instead, so I leave that patch as RFC for now.
>
> Signed-off-by: Marc-André Lureau <address@hidden>
megasas_complete_command() is already doing it, and it calls
megasas_unmap_frame, so it is okay to remove the qemu_sglist_destroy
from there and move it to megasas_unmap_frame. Thanks!
Paolo
> ---
> hw/scsi/megasas.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c
> index ba1afa3c1e..2a16397b3b 100644
> --- a/hw/scsi/megasas.c
> +++ b/hw/scsi/megasas.c
> @@ -465,6 +465,7 @@ static void megasas_unmap_frame(MegasasState *s,
> MegasasCmd *cmd)
> cmd->pa = 0;
> cmd->pa_size = 0;
> clear_bit(cmd->index, s->frame_map);
> + qemu_sglist_destroy(&cmd->qsg);
> }
>
> /*
> -- 2.18.0.547.g1d89318c48
- Re: [Qemu-devel] [PATCH 2/4] tests: fix bdrv-drain leak, (continued)
Re: [Qemu-devel] [Qemu-block] [PATCH 2/4] tests: fix bdrv-drain leak, Max Reitz, 2018/08/13
[Qemu-devel] [PATCH 3/4] monitor: fix oob command leak, Marc-André Lureau, 2018/08/09
[Qemu-devel] [PATCH 4/4] RFC: fix megasas leak, Marc-André Lureau, 2018/08/09
- Re: [Qemu-devel] [PATCH 4/4] RFC: fix megasas leak,
Paolo Bonzini <=
Re: [Qemu-devel] [PATCH 0/4] Memory leak fixes, Eric Blake, 2018/08/09