[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler |
Date: |
Wed, 15 Aug 2018 06:29:11 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
"Emilio G. Cota" <address@hidden> writes:
> On Tue, Aug 14, 2018 at 10:13:12 +0200, Paolo Bonzini wrote:
>> On 13/08/2018 19:11, Emilio G. Cota wrote:
>> > + struct qsp_report rep;
>>
>> Don't like camelcase? But that's really all that I have to remark on
>> this lovely series.
>
> I have a strong aversion to it :-)
I despise it as much as anyone, but CODING_STYLE demands CamelCase for
"type names" (which I interpret as typedef names), and convention (not
codified in CODING_STYLE) demands typedef for struct types.
> But if that's a deal breaker, let me know.
Hold your nose and go with the flow.
- [Qemu-devel] [PATCH 2/3] monitor: show sync profiling info with 'info sync', (continued)
- [Qemu-devel] [PATCH 2/3] monitor: show sync profiling info with 'info sync', Emilio G. Cota, 2018/08/13
- [Qemu-devel] [PATCH 3/3] qsp: track BQL callers directly, Emilio G. Cota, 2018/08/13
- [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Emilio G. Cota, 2018/08/13
- Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Fam Zheng, 2018/08/14
- Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Emilio G. Cota, 2018/08/15
- Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Fam Zheng, 2018/08/15
- Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Emilio G. Cota, 2018/08/15
- Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Emilio G. Cota, 2018/08/16
- Re: [Qemu-devel] [PATCH 1/3] qsp: QEMU's Synchronization Profiler, Fam Zheng, 2018/08/16
Re: [Qemu-devel] [PATCH 0/3] synchronization profiler, no-reply, 2018/08/15