[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 11/13] tests: remove "0.15" prefix for test-q
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v6 11/13] tests: remove "0.15" prefix for test-qmp-cmds |
Date: |
Thu, 16 Aug 2018 09:55:04 +0800 |
User-agent: |
Mutt/1.10.0 (2018-05-17) |
On Wed, Aug 15, 2018 at 03:48:57PM +0200, Thomas Huth wrote:
> On 08/15/2018 03:37 PM, Peter Xu wrote:
> > The "0.15" prefix seems useless. Remove them.
> >
> > Signed-off-by: Peter Xu <address@hidden>
> > ---
> > tests/test-qmp-cmds.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/tests/test-qmp-cmds.c b/tests/test-qmp-cmds.c
> > index ba41a6161e..989819b26d 100644
> > --- a/tests/test-qmp-cmds.c
> > +++ b/tests/test-qmp-cmds.c
> > @@ -286,11 +286,11 @@ int main(int argc, char **argv)
> > {
> > g_test_init(&argc, &argv, NULL);
> >
> > - g_test_add_func("/0.15/dispatch_cmd", test_dispatch_cmd);
> > - g_test_add_func("/0.15/dispatch_cmd_failure",
> > test_dispatch_cmd_failure);
> > - g_test_add_func("/0.15/dispatch_cmd_io", test_dispatch_cmd_io);
> > - g_test_add_func("/0.15/dealloc_types", test_dealloc_types);
> > - g_test_add_func("/0.15/dealloc_partial", test_dealloc_partial);
> > + g_test_add_func("/dispatch_cmd", test_dispatch_cmd);
> > + g_test_add_func("/dispatch_cmd_failure", test_dispatch_cmd_failure);
> > + g_test_add_func("/dispatch_cmd_io", test_dispatch_cmd_io);
> > + g_test_add_func("/dealloc_types", test_dealloc_types);
> > + g_test_add_func("/dealloc_partial", test_dealloc_partial);
>
> Most other tests use a common prefix, so maybe rather replace the "0.15"
> with "qmp-cmd" here? E.g.:
>
> g_test_add_func("/qmp-cmd/dispatch_cmd", test_dispatch_cmd);
>
> ?
I'll drop this patch due to a dup in master. That one has "/qmp"
prefix. Thanks Thomas.
--
Peter Xu
- [Qemu-devel] [PATCH v6 06/13] qapi: remove COMMAND_DROPPED event, (continued)
- [Qemu-devel] [PATCH v6 06/13] qapi: remove COMMAND_DROPPED event, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 05/13] monitor: suspend monitor instead of send CMD_DROP, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 07/13] monitor: restrict response queue length too, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 08/13] monitor: remove "x-oob", turn oob on by default, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 10/13] monitor: add traces for qmp queues, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 09/13] Revert "tests: Add parameter to qtest_init_without_qmp_handshake", Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 11/13] tests: remove "0.15" prefix for test-qmp-cmds, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 13/13] monitor: reduce different code path for oob, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 12/13] tests: add oob functional test for test-qmp-cmds, Peter Xu, 2018/08/15
- Re: [Qemu-devel] [PATCH v6 00/13] monitor: enable OOB by default, Markus Armbruster, 2018/08/28