[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 0/5] tcg: Reorg 128-bit atomic operations
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH 0/5] tcg: Reorg 128-bit atomic operations |
Date: |
Wed, 15 Aug 2018 19:54:47 -0700 |
The other day Emilio noticed that we weren't setting CONFIG_ATOMIC128
for x86_64, despite forcing -mcx16 on the command-line. It seems that
gcc has changed behaviour with version 7.
There's a rather long discussion about this:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80878
It does not appear that gcc will ever quite align with our needs here.
I have added a second configure test, and have split the test to be
used by the rest of QEMU into two compile-time constants. This lets
us refactor the code a bit and remove some conditional compilation.
In addition, no version of gcc supports __sync_compare_and_swap_16
for aarch64. Inline some asm for that case.
I've also checked power8, which does support CONFIG_ATOMIC128.
Comments?
r~
Richard Henderson (5):
tcg: Split CONFIG_ATOMIC128
target/i386: Convert to HAVE_CMPXCHG128
target/s390x: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128
target/arm: Convert to HAVE_CMPXCHG128
target/ppc: Convert to HAVE_CMPXCHG128 and HAVE_ATOMIC128
accel/tcg/atomic_template.h | 22 ++-
include/qemu/atomic128.h | 162 ++++++++++++++++++++++
target/ppc/helper.h | 2 +-
tcg/tcg.h | 29 ++--
accel/tcg/cputlb.c | 3 +-
accel/tcg/user-exec.c | 5 +-
target/arm/helper-a64.c | 259 ++++++++++++++++++------------------
target/i386/mem_helper.c | 9 +-
target/ppc/mem_helper.c | 33 ++++-
target/ppc/translate.c | 115 ++++++++--------
target/s390x/mem_helper.c | 87 ++++++------
configure | 19 +++
12 files changed, 481 insertions(+), 264 deletions(-)
create mode 100644 include/qemu/atomic128.h
--
2.17.1
- [Qemu-devel] [PATCH 0/5] tcg: Reorg 128-bit atomic operations,
Richard Henderson <=