Re: [Qemu-devel] [PATCH v9 0/6] Add support for TPM Physical Presence interface

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH v9 0/6] Add support for TPM Physical Presence 
interface

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
fd04150f40 tpm: add ACPI memory clear interface
e0301517ac acpi: build TPM Physical Presence interface
bc2fb50446 acpi: expose TPM/PPI configuration parameters to firmware via fw_cfg
d0e68c0039 tpm: allocate/map buffer for TPM Physical Presence interface
227b4a27be tpm: add a "ppi" boolean property
e87b544450 hw/i386: add pc-i440fx-3.1 & pc-q35-3.1

=== OUTPUT BEGIN ===
Checking PATCH 1/6: hw/i386: add pc-i440fx-3.1 & pc-q35-3.1...
Use of uninitialized value in concatenation (.) or string at 
./scripts/checkpatch.pl line 2360.
Checking PATCH 2/6: tpm: add a "ppi" boolean property...
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#68: FILE: include/hw/compat.h:4:
+#define HW_COMPAT_3_0 \
+    {\
+        .driver   = "tpm-crb",\
+        .property = "ppi",\
+        .value    = "false",\
+    },\
+    {\
+        .driver   = "tpm-tis",\
+        .property = "ppi",\
+        .value    = "false",\
+    },

total: 1 errors, 0 warnings, 48 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/6: tpm: allocate/map buffer for TPM Physical Presence 
interface...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#70: 
new file mode 100644

total: 0 errors, 1 warnings, 124 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/6: acpi: expose TPM/PPI configuration parameters to firmware 
via fw_cfg...
Checking PATCH 5/6: acpi: build TPM Physical Presence interface...
Checking PATCH 6/6: tpm: add ACPI memory clear interface...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden