[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 4/7] hmp: use l for size argument in memsave/pmem
From: |
Simon Ruderich |
Subject: |
[Qemu-devel] [PATCH v4 4/7] hmp: use l for size argument in memsave/pmemsave |
Date: |
Thu, 16 Aug 2018 11:01:52 +0200 |
i is only 32-bit. To prevent possible truncation when dumping large
memory regions use l which is target long.
Suggested-by: Dr. David Alan Gilbert <address@hidden>
Signed-off-by: Simon Ruderich <address@hidden>
---
hmp-commands.hx | 4 ++--
hmp.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 91dfe51c37..79c158a140 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -818,7 +818,7 @@ ETEXI
{
.name = "memsave",
- .args_type = "val:l,size:i,filename:s",
+ .args_type = "val:l,size:l,filename:s",
.params = "addr size file",
.help = "save to disk virtual memory dump starting at 'addr' of
size 'size'",
.cmd = hmp_memsave,
@@ -832,7 +832,7 @@ ETEXI
{
.name = "pmemsave",
- .args_type = "val:l,size:i,filename:s",
+ .args_type = "val:l,size:l,filename:s",
.params = "addr size file",
.help = "save to disk physical memory dump starting at 'addr' of
size 'size'",
.cmd = hmp_pmemsave,
diff --git a/hmp.c b/hmp.c
index 2aafb50e8e..1fb0724107 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1094,7 +1094,7 @@ void hmp_cpu(Monitor *mon, const QDict *qdict)
void hmp_memsave(Monitor *mon, const QDict *qdict)
{
- uint32_t size = qdict_get_int(qdict, "size");
+ uint64_t size = qdict_get_int(qdict, "size");
const char *filename = qdict_get_str(qdict, "filename");
uint64_t addr = qdict_get_int(qdict, "val");
Error *err = NULL;
@@ -1111,7 +1111,7 @@ void hmp_memsave(Monitor *mon, const QDict *qdict)
void hmp_pmemsave(Monitor *mon, const QDict *qdict)
{
- uint32_t size = qdict_get_int(qdict, "size");
+ uint64_t size = qdict_get_int(qdict, "size");
const char *filename = qdict_get_str(qdict, "filename");
uint64_t addr = qdict_get_int(qdict, "val");
Error *err = NULL;
--
2.17.1
- [Qemu-devel] [PATCH v4 0/7] qmp/hmp: add pmemload command, Simon Ruderich, 2018/08/16
- [Qemu-devel] [PATCH v4 5/7] hmp: use F for filename arguments in memsave/pmemsave, Simon Ruderich, 2018/08/16
- [Qemu-devel] [PATCH v4 4/7] hmp: use l for size argument in memsave/pmemsave,
Simon Ruderich <=
- [Qemu-devel] [PATCH v4 2/7] cpus: convert qmp_memsave/qmp_pmemsave to use qemu_open, Simon Ruderich, 2018/08/16
- [Qemu-devel] [PATCH v4 7/7] hmp: add pmemload command, Simon Ruderich, 2018/08/16
- [Qemu-devel] [PATCH v4 6/7] qmp: add pmemload command, Simon Ruderich, 2018/08/16
- [Qemu-devel] [PATCH v4 3/7] cpus: use size_t in qmp_memsave/qmp_pmemsave, Simon Ruderich, 2018/08/16