[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 6/8] tests/device-introspection: Check that the q
From: |
Thomas Huth |
Subject: |
[Qemu-devel] [PATCH v2 6/8] tests/device-introspection: Check that the qom-tree and qtree do not change |
Date: |
Thu, 16 Aug 2018 13:35:56 +0200 |
Introspection should not change the qom-tree / qtree, so we should check
this in the device-introspect-test, too. This patch helped to find lots
of instrospection bugs during the QEMU v3.0 soft/hard-freeze period in the
last two months.
Signed-off-by: Thomas Huth <address@hidden>
---
tests/device-introspect-test.c | 23 +++++++++++++++++++----
1 file changed, 19 insertions(+), 4 deletions(-)
diff --git a/tests/device-introspect-test.c b/tests/device-introspect-test.c
index 0b4f221..a38193b 100644
--- a/tests/device-introspect-test.c
+++ b/tests/device-introspect-test.c
@@ -103,7 +103,14 @@ static QList *device_type_list(bool abstract)
static void test_one_device(const char *type)
{
QDict *resp;
- char *help, *qom_tree;
+ char *help;
+ char *qom_tree_start, *qom_tree_end;
+ char *qtree_start, *qtree_end;
+
+ g_test_message("Testing device '%s'", type);
+
+ qom_tree_start = hmp("info qom-tree");
+ qtree_start = hmp("info qtree");
resp = qmp("{'execute': 'device-list-properties',"
" 'arguments': {'typename': %s}}",
@@ -115,10 +122,18 @@ static void test_one_device(const char *type)
/*
* Some devices leave dangling pointers in QOM behind.
- * "info qom-tree" has a good chance at crashing then
+ * "info qom-tree" or "info qtree" have a good chance at crashing then.
+ * Also make sure that the tree did not change.
*/
- qom_tree = hmp("info qom-tree");
- g_free(qom_tree);
+ qom_tree_end = hmp("info qom-tree");
+ g_assert_cmpstr(qom_tree_start, ==, qom_tree_end);
+ g_free(qom_tree_start);
+ g_free(qom_tree_end);
+
+ qtree_end = hmp("info qtree");
+ g_assert_cmpstr(qtree_start, ==, qtree_end);
+ g_free(qtree_start);
+ g_free(qtree_end);
}
static void test_device_intro_list(void)
--
1.8.3.1
- [Qemu-devel] [PATCH v2 3/8] hw/timer/mc146818rtc: White space clean-up, (continued)
- [Qemu-devel] [PATCH v2 3/8] hw/timer/mc146818rtc: White space clean-up, Thomas Huth, 2018/08/16
- [Qemu-devel] [PATCH v2 4/8] hw/timer/mc146818rtc: Fix introspection problem, Thomas Huth, 2018/08/16
- [Qemu-devel] [PATCH v2 8/8] MAINTAINERS: add maintainers for qtest, Thomas Huth, 2018/08/16
- [Qemu-devel] [PATCH v2 5/8] tests: Skip old versioned machine types in quick testing mode, Thomas Huth, 2018/08/16
- [Qemu-devel] [PATCH v2 7/8] tests/device-introspect: Test with all machines, not only with "none", Thomas Huth, 2018/08/16
- [Qemu-devel] [PATCH v2 6/8] tests/device-introspection: Check that the qom-tree and qtree do not change,
Thomas Huth <=
- Re: [Qemu-devel] [PATCH v2 0/8] Various qtest-related patches and a mc146818rtc fix, Paolo Bonzini, 2018/08/17