Re: [Qemu-devel] [PATCH v2 00/60] json: Fixes, error reporting improvements, cleanups

[Markus Armbruster]

address@hidden writes:

> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
[...]
> Checking PATCH 4/60: qmp-cmd-test: Split off qmp-test...
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #48: 
> new file mode 100644

False positive: the patch does update MAINTAINERS.  Surprising, since
commit 1a6fad0c3bd "checkpatch: reduce MAINTAINERS update message
frequency" suppresses this.  Fam, is patchew running an outdated version
of checkpatch?

>
> total: 0 errors, 1 warnings, 460 lines checked
[...]
> Checking PATCH 15/60: check-qjson: Cover interpolation more thoroughly...
> ERROR: space required after that close brace '}'
> #179: FILE: tests/check-qjson.c:1122:
> +            {}}));

I consider this a false positive.  We do require space after } in things
like } else.  We don't in complex initializes, as far as I know.

> total: 1 errors, 0 warnings, 207 lines checked
[...]
> Checking PATCH 55/60: json: Clean up headers...
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #72: 
> deleted file mode 100644

False positive: MAINTAINERS matches the deleted files' directory, and
more files remain there.

> total: 0 errors, 1 warnings, 155 lines checked
>
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> Checking PATCH 56/60: docs/interop/qmp-spec: How to force known good parser 
> state...
> Checking PATCH 57/60: tests/drive_del-test: Fix harmless JSON interpolation 
> bug...
> Checking PATCH 58/60: json: Keep interpolation state in JSONParserContext...
> Checking PATCH 59/60: json: Improve safety of qobject_from_jsonf_nofail() & 
> friends...
> Checking PATCH 60/60: json: Support %% in JSON strings when interpolating...
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to address@hidden