Re: [Qemu-devel] [PULL 0/7] Linux user for 3.1 patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 0/7] Linux user for 3.1 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
4526b6d422 linux-user: add QEMU_IFLA_INFO_KIND nested type for tun
3e38cd31f6 linux-user: update netlink route types
f497361d67 linux-user: introduce QEMU_RTA_* to use with rtattr_type_t
ccb71001f9 linux-user: fix recvmsg()/recvfrom() with netlink and MSG_TRUNC
7f1171c163 sh4: fix use_icount with linux-user
1b749aea90 linux-user: fix 32bit g2h()/h2g()
28fe264aa2 qemu-binfmt-conf.sh: add x86_64 target

=== OUTPUT BEGIN ===
Checking PATCH 1/7: qemu-binfmt-conf.sh: add x86_64 target...
WARNING: line over 80 characters
#29: FILE: scripts/qemu-binfmt-conf.sh:17:
+x86_64_magic='\x7fELF\x02\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\x3e\x00'

ERROR: line over 90 characters
#30: FILE: scripts/qemu-binfmt-conf.sh:18:
+x86_64_mask='\xff\xff\xff\xff\xff\xfe\xfe\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

total: 1 errors, 1 warnings, 18 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/7: linux-user: fix 32bit g2h()/h2g()...
Checking PATCH 3/7: sh4: fix use_icount with linux-user...
Checking PATCH 4/7: linux-user: fix recvmsg()/recvfrom() with netlink and 
MSG_TRUNC...
Checking PATCH 5/7: linux-user: introduce QEMU_RTA_* to use with 
rtattr_type_t...
Checking PATCH 6/7: linux-user: update netlink route types...
Checking PATCH 7/7: linux-user: add QEMU_IFLA_INFO_KIND nested type for tun...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden