[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] virtio-vga: fix reset
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] virtio-vga: fix reset |
Date: |
Tue, 21 Aug 2018 13:25:11 +0200 |
User-agent: |
NeoMutt/20180622 |
> > @@ -179,8 +179,12 @@ static void virtio_vga_realize(VirtIOPCIProxy
> > *vpci_dev, Error **errp)
> > static void virtio_vga_reset(DeviceState *dev)
> > {
> > VirtIOVGA *vvga = VIRTIO_VGA(dev);
> > - vvga->vdev.enable = 0;
> >
> > + /* reset virtio-gpu */
> > + virtio_gpu_reset(VIRTIO_DEVICE(&vvga->vdev));
> > +
> > + /* reset vga */
> > + vga_common_reset(&vvga->vga);
>
> Ah, I only tested with vga_common_reset(). I was missing the
> virtio_gpu_reset() part.
/me too (at least back then when discussing -rc4), took me some
debugging to figure ...
> I assume you tested it?
Sure.
cheers,
Gerd