Re: [Qemu-devel] [PATCH 0/4] Fix socket chardev regression

[Daniel P . Berrangé]

On Tue, Aug 21, 2018 at 04:04:45PM +0200, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Aug 21, 2018 at 8:29 AM Peter Xu <address@hidden> wrote:
> > I fully agree that current way is not ideal since basically the
> > backend should not depend on the frontend, but now we have the
> > gcontext as an exception then the backend will somehow depend on the
> > frontend.  If you don't like the way I proposed, another thing I am
> > thinking is that whether we can assign the gcontext for the chardev
> > backend before initialization of it (or by parsing the backend &
> > frontend relationships before init of backends), then we assure that
> > we never change the gcontext of any chardev backends.  Though that
> 
> Yes, I think that's a cleaner solution. I suggested to use an iothread
> argument in the cover letter.
> 
> Paolo, Daniel, any opinion?

Never changing the GContext once initialized is much nicer. I think I
had suggested that before when this code was first proposed.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|