qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga


From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga is compiled in
Date: Wed, 22 Aug 2018 12:30:31 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2018-08-22 11:54, Juan Quintela wrote:
> This is only for x86* architecture.
> 
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  tests/Makefile.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 116e93cdb6..d524e1bdeb 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -257,7 +257,7 @@ check-qtest-i386-y += tests/hd-geo-test$(EXESUF)
>  gcov-files-i386-y += hw/block/hd-geometry.c
>  check-qtest-i386-y += tests/boot-order-test$(EXESUF)
>  check-qtest-i386-y += tests/bios-tables-test$(EXESUF)
> -check-qtest-i386-y += tests/boot-serial-test$(EXESUF)
> +check-qtest-i386-$(CONFIG_SGA) += tests/boot-serial-test$(EXESUF)

Reviewed-by: Thomas Huth <address@hidden>

Off-topic: I wonder whether we could even deprecate the SGA device
nowadays, since the main seabios now can redirect the console to the
serial port, too?

 Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]