Re: [Qemu-devel] [PATCH v3 03/10] check: Only test isa-testdev when it is compiled in

[Juan Quintela]

Thomas Huth <address@hidden> wrote:
> On 2018-08-22 11:54, Juan Quintela wrote:
>> Once there, untangle endianness-test and boot-serial-test.
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>> 
>> --
>> 
>> boot-serial-test don't depend on isa-testdev.  Thanks Thomas.
>> 
>> Signed-off-by: Juan Quintela <address@hidden>
>
> Please remove the duplicated Sob.

Found the problem!!!!

As the cool man that I am, I put the signed-off line with a hook.  And I
updated the hook to the last version in git upstream, to be, you know
cool.

And the new version don't check that the line is already there.

SOB=$(git var GIT_COMMITTER_IDENT | sed -n 's/^\(.*>\).*$/Signed-off-by: \1/p')
git interpret-trailers --in-place --trailer "$SOB" "$COMMIT_MSG_FILE"

Will try to get it right.

Later, Juan.