qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [qemu-s390x] [PATCH v4 1/3] target/s390x: use regular s


From: Thomas Huth
Subject: Re: [Qemu-devel] [qemu-s390x] [PATCH v4 1/3] target/s390x: use regular spaces in translate.c
Date: Thu, 23 Aug 2018 07:53:48 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2018-08-22 16:40, Pavel Zbitskiy wrote:
> In a few places translate.c contains non-breaking spaces (0xc2 0xa0)
> instead of regular ones (0x20):
> 
>   7c 7c c2 a0 63 63
>   7c 7c 20    63 63
>   |  |        c  c
> 
> This confuses some text editors.

Without your patch:

$ file target/s390x/translate.c
target/s390x/translate.c: C source, UTF-8 Unicode text

With your patch:

$ file target/s390x/translate.c
target/s390x/translate.c: C source, ASCII text

Looks like you've got all spots :-)

Reviewed-by: Thomas Huth <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]