Re: [Qemu-devel] [PULL v2 00/73] Misc patches for 2018-08-21

[Marc-André Lureau]

Hi
On Thu, Aug 23, 2018 at 3:31 PM Peter Maydell <address@hidden> wrote:
>
> On 23 August 2018 at 12:36, Paolo Bonzini <address@hidden> wrote:
> > The following changes since commit 659b11e7a7239529cfdb4968418268ff9aa22d88:
> >
> >   Merge remote-tracking branch 
> > 'remotes/vivier2/tags/linux-user-for-3.1-pull-request' into staging 
> > (2018-08-21 11:36:15 +0100)
> >
> > are available in the Git repository at:
> >
> >   git://github.com/bonzini/qemu.git tags/for-upstream
> >
> > for you to fetch changes up to 07c8c1c9311b81cbf3bcc49d4fed18e1d889a8f2:
> >
> >   test-char: add socket reconnect test (2018-08-23 13:32:50 +0200)
> >
> > I removed the offending patch.
>
> Test failure on FreeBSD:
>
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> gtester -k --verbose -m=quick tests/test-char
> TEST: tests/test-char... (pid=16190)
>   /char/null:                                                          OK
>   /char/invalid:                                                       OK
>   /char/ringbuf:                                                       OK
>   /char/mux:                                                           OK
>   /char/stdio:                                                         OK
>   /char/pipe:                                                          OK
>   /char/file:                                                          OK
>   /char/file-fifo:                                                     OK
>   /char/udp:                                                           OK
>   /char/serial:                                                        OK
>   /char/hotswap:                                                       OK
>   /char/socket/basic:                                                  OK
>   /char/socket/reconnect:                                              FAIL
> GTester: last random seed: R02S521380d9c12f1dac3ad1763bf5665c27
> (pid=16367)
>   /char/socket/fdpass:                                                 OK
> FAIL: tests/test-char
> **
> ERROR:tests/test-char.c:353:char_socket_test_common: assertion failed:
> (object_property_get_bool(OBJECT(chr_client), "connected",
> &error_abort))
>

Hmm, it looks like a race that pre-existed char_socket_test_common(),
we wait for the server to be connected, and check both client and
server have the connected option set. It may be that the client hasn't
yet processed the connection event.

Paolo, can you drop the test?

> thanks
> -- PMM
>


-- 
Marc-André Lureau