Re: [Qemu-devel] [PULL v3 00/69] Misc patches for 2018-08-21

[Peter Maydell]

On 23 August 2018 at 17:25, Paolo Bonzini <address@hidden> wrote:
> On 23/08/2018 18:16, Peter Maydell wrote:
>>
>> tests/libqtest.c: In function 'qtest_is_old_versioned_machine':
>> tests/libqtest.c:1019:13: warning: array subscript has type 'char'
>> [-Wchar-subscripts]
>>              if (!isdigit(*chr) && *chr != '.') {
>>              ^
>>
>> Code should be using qemu_isdigit(). We don't enforce -Werror
>> on NetBSD, though, so we could let this through and fix it up
>> later...
>
> As you prefer.  I can send a v4 too.
>
>> Test failure on x86-64 Linux (debug build):

>> I'm just checking whether that fails consistently or if it's a random/
>> intermittent.
>
> That would be strange, since I'm not touching the block layer at all
> (not my turf!)...

It does seem to be intermittent.

If you're ok with doing a v4 for the isdigit thing that's
probably the cleanest way to do it.

thanks
-- PMM