Re: [Qemu-devel] [PATCH] pc: acpi: revert back to 1 SRAT entry for hotpluggable area

[Eduardo Habkost]

On Thu, Aug 23, 2018 at 10:14:06AM +0200, Igor Mammedov wrote:
> On Wed, 22 Aug 2018 15:01:12 -0300
> Eduardo Habkost <address@hidden> wrote:
[...]
> > However, have you considered keeping adding separate entries for
> > NVDIMM devices only (so we follow the spec), but add a single
> > (numa_nodes-1, MEM_AFFINITY_HOTPLUGGABLE|MEM_AFFINITY_ENABLED)
> > entry to the rest?
> Indeed, I did. It doesn't work either.

When exactly it didn't work?  Did nvdimm + memory hotplug ever
worked together on Windows guests?

For all the other cases there should be absolutely no difference:

nvdimm users would still get a spec-compliant SRAT table (like on
QEMU 3.0).

Memory hotplug users w/o nvdimm would get the same ACPI table
that they would get after applying this patch (i.e. the one we
had before commit 848a1cc1e ("hw/acpi-build: build SRAT memory
affinity structures for DIMM devices").

-- 
Eduardo