Re: [Qemu-devel] [PATCH 3/8] hw/display/bcm2835_fb: Drop unused size and pitch fields

[Richard Henderson]

On 08/14/2018 07:44 AM, Peter Maydell wrote:
> The BCM2835FBState struct has a 'pitch' field which is a
> cached copy of xres * (bpp >> 3), and a 'size' field which is
> a cached copy of pitch * yres. However we don't actually do
> anything with these fields; delete them. We retain the
> now-unused slots in the VMState struct for migration
> compatibility.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  include/hw/display/bcm2835_fb.h |  4 ----
>  hw/display/bcm2835_fb.c         | 19 ++++++++-----------
>  2 files changed, 8 insertions(+), 15 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>


r~