[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 09/13] jobs: remove .exit callback
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 09/13] jobs: remove .exit callback |
Date: |
Mon, 27 Aug 2018 15:47:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-24 00:22, John Snow wrote:
> Now that all of the jobs use the component finalization callbacks,
> there's no use for the heavy-hammer .exit callback anymore.
>
> job_exit becomes a glorified type shim so that we can call
> job_completed from aio_bh_schedule_oneshot.
>
> Move these three functions down into job.c to eliminate a
> forward reference.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> include/qemu/job.h | 11 -------
> job.c | 77
> +++++++++++++++++++++--------------------------
> tests/test-blockjob-txn.c | 4 +--
> 3 files changed, 36 insertions(+), 56 deletions(-)
[...]
> diff --git a/tests/test-blockjob-txn.c b/tests/test-blockjob-txn.c
> index ef29f35e44..86606f92b3 100644
> --- a/tests/test-blockjob-txn.c
> +++ b/tests/test-blockjob-txn.c
> @@ -24,7 +24,7 @@ typedef struct {
> int *result;
> } TestBlockJob;
>
> -static void test_block_job_exit(Job *job)
> +static void test_block_job_clean(Job *job)
> {
> BlockJob *bjob = container_of(job, BlockJob, job);
> BlockDriverState *bs = blk_bs(bjob->blk);
> @@ -73,7 +73,7 @@ static const BlockJobDriver test_block_job_driver = {
> .user_resume = block_job_user_resume,
> .drain = block_job_drain,
> .run = test_block_job_run,
> - .exit = test_block_job_exit,
> + .clean = test_block_job_clean,
> },
> };
Not sure whether this change warrants its own patch, but it probably
should be noted in the commit message.
With that done (or with this change split off into its own patch):
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 03/13] block/stream: add block job creation flags, (continued)
- [Qemu-devel] [PATCH v2 06/13] block/commit: refactor stream to use job callbacks, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 02/13] block/mirror: add block job creation flags, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 10/13] qapi/block-commit: expose new job properties, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 05/13] block/mirror: conservative mirror_exit refactor, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 09/13] jobs: remove .exit callback, John Snow, 2018/08/23
- Re: [Qemu-devel] [PATCH v2 09/13] jobs: remove .exit callback,
Max Reitz <=
- [Qemu-devel] [PATCH v2 07/13] tests/blockjob: replace Blockjob with Job, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 04/13] block/commit: refactor commit to use job callbacks, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 13/13] block/backup: qapi documentation fixup, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 12/13] qapi/block-stream: expose new job properties, John Snow, 2018/08/23
- [Qemu-devel] [PATCH v2 11/13] qapi/block-mirror: expose new job properties, John Snow, 2018/08/23