[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 01/13] monitor: simplify monitor_qmp_setup_ha
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v6 01/13] monitor: simplify monitor_qmp_setup_handlers_bh |
Date: |
Tue, 28 Aug 2018 11:26:44 +0800 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Aug 27, 2018 at 01:29:29PM +0200, Markus Armbruster wrote:
> > @@ -4624,15 +4624,10 @@ static void monitor_qmp_setup_handlers_bh(void
> > *opaque)
> > Monitor *mon = opaque;
> > GMainContext *context;
> >
> > - if (mon->use_io_thread) {
> > - /* Use @mon_iothread context */
> > - context = monitor_get_io_context();
> > - assert(context);
> > - } else {
> > - /* Use default main loop context */
> > - context = NULL;
> > - }
> > -
> > + assert(mon->use_io_thread);
> > + /* Use @mon_iothread context */
>
> Mind if I drop this comment?
Yes, please.
>
> > + context = monitor_get_io_context();
> > + assert(context);
> > qemu_chr_fe_set_handlers(&mon->chr, monitor_can_read, monitor_qmp_read,
> > monitor_qmp_event, NULL, mon, context, true);
> > monitor_list_append(mon);
>
> R-by stands, of course.
Regards,
--
Peter Xu
- [Qemu-devel] [PATCH v6 00/13] monitor: enable OOB by default, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 01/13] monitor: simplify monitor_qmp_setup_handlers_bh, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 02/13] qapi: Fix build_params() for empty parameter list, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 03/13] qapi: remove error checks for event emission, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 04/13] monitor: move need_resume flag into monitor struct, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 06/13] qapi: remove COMMAND_DROPPED event, Peter Xu, 2018/08/15
- [Qemu-devel] [PATCH v6 05/13] monitor: suspend monitor instead of send CMD_DROP, Peter Xu, 2018/08/15