[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/9] char-fe: set_handlers() needs an associted
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 5/9] char-fe: set_handlers() needs an associted chardev |
|
Date: |
Thu, 30 Aug 2018 16:57:55 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> It is futile to call qemu_chr_fe_set_handlers() without an associated
> chardev, because the function is doing nothing in that case, not even
> reporting an error, it would likely be a programming error. Let's not
> handle that hypothetical case.
>
> (fwiw, I introduced the check in commit
> 94a40fc56036b5058b0b194d9e372a22e65ce7be, that was a mistake imho)
>
> Signed-off-by: Marc-André Lureau <address@hidden>
In your subject, s/associted/associated/.
- [Qemu-devel] [PATCH 1/9] char.h: fix gtk-doc comment style, (continued)
- [Qemu-devel] [PATCH 1/9] char.h: fix gtk-doc comment style, Marc-André Lureau, 2018/08/27
- [Qemu-devel] [PATCH 3/9] chardev: use a child source for qio input source, Marc-André Lureau, 2018/08/27
- [Qemu-devel] [PATCH 4/9] char: update the mux hanlders in class callback, Marc-André Lureau, 2018/08/27
- [Qemu-devel] [PATCH 7/9] chardev: add a note about frontend sources and context switch, Marc-André Lureau, 2018/08/27
- [Qemu-devel] [PATCH 5/9] char-fe: set_handlers() needs an associted chardev, Marc-André Lureau, 2018/08/27
- Re: [Qemu-devel] [PATCH 5/9] char-fe: set_handlers() needs an associted chardev,
Markus Armbruster <=
- [Qemu-devel] [PATCH 6/9] terminal3270: do not use backend timer sources, Marc-André Lureau, 2018/08/27
[Qemu-devel] [PATCH 8/9] char-pty: remove check for connection on write, Marc-André Lureau, 2018/08/27
[Qemu-devel] [PATCH 9/9] char-pty: remove write_lock usage, Marc-André Lureau, 2018/08/27