[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] hw/arm/exynos4210: fix Exynos4210 UART support
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH] hw/arm/exynos4210: fix Exynos4210 UART support |
|
Date: |
Fri, 31 Aug 2018 12:31:00 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-31 12:23, Bartlomiej Zolnierkiewicz wrote:
> commit 97274d0c05d4 ("hw/char/exynos4210_uart.c: Remove unneeded
> handling of NULL chardev") broke Exynos4210 support as it removed
> NULL 'Chardev *chr' handling from exynos4210_uart_create() and
> currently exynos4210_init() always passes NULL as 'Chardev *chr'
> argument to exynos4210_uart_create() calls. Fix it by adding
> missing serial_hd() calls to exynos4210_init().
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <address@hidden>
> ---
> hw/arm/exynos4210.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Thomas Huth <address@hidden>
PS: If you've got some spare time, maybe you could consider to also
write a regression test (e.g. for tests/boot-serial-test.c) to avoid
that this happens again?