[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 07/10] file-posix: Forbid trying to change un
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH v2 07/10] file-posix: Forbid trying to change unsupported options during reopen |
Date: |
Wed, 5 Sep 2018 14:49:22 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-09-03 16:34, Alberto Garcia wrote:
> The file-posix code is used for the "file", "host_device" and
> "host_cdrom" drivers, and it allows reopening images. However the only
> option that is actually processed is "x-check-cache-dropped", and
> changes in all other options (e.g. "filename") are silently ignored:
>
> (qemu) qemu-io virtio0 "reopen -o file.filename=no-such-file"
>
> While we could allow changing some of the other options, let's keep
> things as they are for now but return an error if the user tries to
> change any of them.
>
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
> block/file-posix.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 05/10] block: Allow child references on reopen, (continued)
- [Qemu-devel] [PATCH v2 09/10] block: Allow changing 'detect-zeroes' on reopen, Alberto Garcia, 2018/09/03
- [Qemu-devel] [PATCH v2 08/10] block: Allow changing 'discard' on reopen, Alberto Garcia, 2018/09/03
- [Qemu-devel] [PATCH v2 02/10] file-posix: x-check-cache-dropped should default to false on reopen, Alberto Garcia, 2018/09/03
- [Qemu-devel] [PATCH v2 06/10] block: Forbid trying to change unsupported options during reopen, Alberto Garcia, 2018/09/03
- [Qemu-devel] [PATCH v2 07/10] file-posix: Forbid trying to change unsupported options during reopen, Alberto Garcia, 2018/09/03
- Re: [Qemu-devel] [PATCH v2 07/10] file-posix: Forbid trying to change unsupported options during reopen,
Max Reitz <=