[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-3.1 v10 31/31] iotests: Test json:{} filenam
From: |
Alberto Garcia |
Subject: |
Re: [Qemu-devel] [PATCH for-3.1 v10 31/31] iotests: Test json:{} filenames of internal BDSs |
Date: |
Wed, 05 Sep 2018 16:44:22 +0200 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 09 Aug 2018 11:35:28 PM CEST, Max Reitz wrote:
> + vm.shutdown()
> +
> + #assert top_name[:5] == 'json:'
> + #top_options = json.loads(top_name[5:])
> +
> + #if filter_node_name:
> + # # This should be present and set
> + # assert top_options['backing']['driver'] == 'commit_top'
> + # # And the mid image is commit_top's backing image
> + # mid_options = top_options['backing']['backing']
> + #else:
> + # # The mid image should appear as the immediate backing BDS
> + # # of top
> + # mid_options = top_options['backing']
> +
> + #assert mid_options['driver'] == iotests.imgfmt
> + #assert mid_options['file']['filename'] == mid_img_path
What's with all these commented lines? I don't see how you are checking
the filename in this test, it's also not in the output file.
Berto
- Re: [Qemu-devel] [PATCH for-3.1 v10 31/31] iotests: Test json:{} filenames of internal BDSs,
Alberto Garcia <=