Re: [Qemu-devel] [PATCH v5 04/16] block/commit: refactor commit to use job callbacks

[Max Reitz]

On 2018-09-06 15:02, John Snow wrote:
> Use the component callbacks; prepare, abort, and clean.
> 
> NB: prepare is only called when the job has not yet failed;
> and abort can be called after prepare.
> 
> complete -> prepare -> abort -> clean
> complete -> abort -> clean
> 
> During refactor, a potential problem with bdrv_drop_intermediate
> was identified, The patched behavior is no worse than the pre-patch

(s/T/t/)

(Max)

> behavior, so leave a FIXME for now to be fixed in a future patch.
> 
> Signed-off-by: John Snow <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
> ---
>  block/commit.c | 92 
> ++++++++++++++++++++++++++++++++--------------------------
>  1 file changed, 51 insertions(+), 41 deletions(-)

signature.asc
Description: OpenPGP digital signature