[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local sto
|
From: |
Emilio G. Cota |
|
Subject: |
Re: [Qemu-devel] [PATCH 5/6] target/i386/translate: use thread-local storage in !user-mode |
|
Date: |
Tue, 11 Sep 2018 13:21:49 -0400 |
|
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Tue, Sep 11, 2018 at 13:24:03 +0200, Paolo Bonzini wrote:
> On 10/09/2018 14:30, Emilio G. Cota wrote:
> >> I'm confused - as we can have multi-threaded user space don't the same
> >> requirements apply?
> > In user-mode, code generation is serialized by mmap_lock.
> > Making these per-thread would just waste TLS space.
>
> It's stupid question time! How can the TLS work? tcg_x86_init is only
> called once, the first time cpu_exec_realizefn is called.
>
> Either they can be kept in non-TLS, or you should move them to DisasContext.
Yes, the latter is the Right Thing (tm), as both you and Richard
pointed out. I should have done that in the first place.
Will send a v3 with just this change + the configure patch.
Thanks,
Emilio
- [Qemu-devel] [PATCH 6/6] configure: enable mttcg for i386 and x86_64, (continued)
[Qemu-devel] [PATCH 2/6] test-rcu-list: avoid torn accesses to n_reclaims and n_nodes_removed, Emilio G. Cota, 2018/09/03
[Qemu-devel] [PATCH 1/6] qsp: drop atomics when using the seqlock, Emilio G. Cota, 2018/09/03