Re: [Qemu-devel] [PATCH V12-fix 01/19] filter-rewriter: Add TCP state machine and fix memory leak in connection_track_table

[Eric Blake]

On 9/13/18 7:58 PM, Zhang Chen wrote:

> > > Signed-off-by: zhanghailiang <address@hidden>
> > > Signed-off-by: Zhang Chen <address@hidden>
> > > Signed-off-by: Zhang Chen <address@hidden>
> >
> > Should both of these last two S-o-b be present?
>
> Maybe it will be more convenient to contact me, I use both of the email. :)

I can't tell you it's wrong, only that it is unusual. Statistics-wise, 
it's nicer if .mailmap consolidates multiple working email addresses 
into one individual, both for the sake of 'git shortlog' author 
attribution, and for making it easier to grep the git logs for your 
contributions regardless of which of the two emails that particular 
commit was sent under. If it were me, I'd rely on .mailmap rather than 
trying to double-sign my contributions.

Also, since one email appears to be personal while the other Intel, your 
company may have specific rules on which email address to use (was the 
patch written on your time or on Intel time?) (here, I have to admit 
that Red Hat's policy allows me to choose either my personal or my work 
email for open source contributions, regardless of whether I did it on 
my time or company time, but very few companies have equivalent policies 
that relaxed).

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org