[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 2/4] block/rbd: Attempt to parse legacy filenames
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL 2/4] block/rbd: Attempt to parse legacy filenames |
Date: |
Fri, 14 Sep 2018 12:49:22 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 9/12/18 8:18 AM, Jeff Cody wrote:
When we converted rbd to get rid of the older key/value-centric
encoding format, we broke compatibility with image files with backing
file strings encoded in the old format.
This leaves a bit of an ugly conundrum, and a hacky solution.
+ /* Take care whenever deciding to actually deprecate; once this ability
+ * is removed, we will not be able to open any images with
legacy-styled
+ * backing image strings. */
+ error_report("RBD options encoded in the filename as keyvalue pairs "
+ "is deprecated. Future versions may cease to parse "
+ "these options in the future.");
Fam spotted offline that " in the future" is redundant with "Future
versions", if you want to respin the pull request.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [Qemu-devel] [PULL 0/4] Block patches, Jeff Cody, 2018/09/12
- [Qemu-devel] [PULL 4/4] block/rbd: add deprecation documentation for filename keyvalue pairs, Jeff Cody, 2018/09/12
- [Qemu-devel] [PULL 3/4] block/rbd: add iotest for rbd legacy keyvalue filename parsing, Jeff Cody, 2018/09/12
- [Qemu-devel] [PULL 1/4] block/rbd: pull out qemu_rbd_convert_options, Jeff Cody, 2018/09/12
- [Qemu-devel] [PULL 2/4] block/rbd: Attempt to parse legacy filenames, Jeff Cody, 2018/09/12
- Re: [Qemu-devel] [PULL 2/4] block/rbd: Attempt to parse legacy filenames,
Eric Blake <=
- Re: [Qemu-devel] [PULL 0/4] Block patches, Jeff Cody, 2018/09/25